Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test of builders #88

Merged
merged 10 commits into from
Oct 16, 2024
Merged

Integration test of builders #88

merged 10 commits into from
Oct 16, 2024

Conversation

tuler
Copy link
Member

@tuler tuler commented Oct 15, 2024

integration tests for builders

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b553b59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Coverage Report for ./apps/cli

Status Category Percentage Covered / Total
🔵 Lines 28.52% 247 / 866
🔵 Statements 28.6% 250 / 874
🔵 Functions 32.03% 41 / 128
🔵 Branches 23.63% 95 / 402
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/cli/src/exec.ts 75% 64.28% 100% 75% 42, 45, 88-92, 96-97, 100
apps/cli/src/builder/directory.ts 100% 100% 100% 100%
Generated in workflow #164 for commit b553b59 by the Vitest Coverage Report Action

endersonmaia
endersonmaia requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes in the test case descriptions, didn't do for every case, but hope you get the idea.

apps/cli/test/builder/diretory.test.ts Outdated Show resolved Hide resolved
apps/cli/test/builder/diretory.test.ts Outdated Show resolved Hide resolved
apps/cli/test/builder/diretory.test.ts Outdated Show resolved Hide resolved
apps/cli/test/builder/diretory.test.ts Outdated Show resolved Hide resolved
apps/cli/test/builder/diretory.test.ts Outdated Show resolved Hide resolved
apps/cli/test/builder/diretory.test.ts Outdated Show resolved Hide resolved
apps/cli/test/builder/diretory.test.ts Outdated Show resolved Hide resolved
apps/cli/test/builder/docker.test.ts Outdated Show resolved Hide resolved
apps/cli/test/builder/docker.test.ts Outdated Show resolved Hide resolved
endersonmaia
endersonmaia approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but will suggest some improvements for other PRs.

The fallback message should be a WARN message with less details.

Instead of error executing 'xgenext2fs', falling back to docker execution using image 'cartesi/sdk:0.11.0' we cold shw something like:

WARN: xgenext2fs not found, using cartesi/sdk container image

For better builder code coverage, we should also include tests for sqfs type filesystems.

@tuler
Copy link
Member Author

tuler commented Oct 16, 2024

For better builder code coverage, we should also include tests for sqfs type filesystems.

done

@tuler
Copy link
Member Author

tuler commented Oct 16, 2024

Instead of error executing 'xgenext2fs', falling back to docker execution using image 'cartesi/sdk:0.11.0' we cold shw something like:

yeah, interpreting the errors raised by xgenext2fs cli is kind of hard

@tuler tuler merged commit 6de0404 into feature/config-file Oct 16, 2024
2 checks passed
@tuler tuler deleted the feature/config-file-tests branch October 16, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endersonmaia endersonmaia endersonmaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuler @endersonmaia